Skip to content

Revert "🐛 Fix wrong go-style UUID regexp - made portal links fail (#6268)" #6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mrnicegyu11
Copy link
Member

This reverts commit 7e10cd6.

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@mrnicegyu11 mrnicegyu11 self-assigned this Aug 29, 2024
@mrnicegyu11 mrnicegyu11 added the High Priority a totally crucial bug/feature to be fixed asap label Aug 29, 2024
@mrnicegyu11 mrnicegyu11 added this to the Eisbock milestone Aug 29, 2024
Copy link

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (827cab9).
Report is 481 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6269      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1471    +1461     
  Lines         214   61011   +60797     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53788   +53607     
- Misses         23    6910    +6887     
- Partials       10     313     +303     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1421 files with indirect coverage changes

@sanderegg sanderegg merged commit c1f604e into ITISFoundation:master Aug 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority a totally crucial bug/feature to be fixed asap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants