Skip to content

🐛Traefik v3: adapt Go regexp (2nd trial) #6273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 30, 2024

What do these changes do?

  • this should fix the CORS error in the deployments.
  • might break it in the local builds

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Aug 30, 2024
@sanderegg sanderegg added this to the Eisbock milestone Aug 30, 2024
@sanderegg sanderegg self-assigned this Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.1%. Comparing base (cafbf96) to head (f001553).
Report is 484 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6273      +/-   ##
=========================================
+ Coverage    84.5%   88.1%    +3.5%     
=========================================
  Files          10    1476    +1466     
  Lines         214   61075   +60861     
  Branches       25    2063    +2038     
=========================================
+ Hits          181   53849   +53668     
- Misses         23    6911    +6888     
- Partials       10     315     +305     
Flag Coverage Δ
integrationtests 64.8% <ø> (?)
unittests 86.1% <ø> (+1.5%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ules/dynamic_sidecar/docker_service_specs/proxy.py 100.0% <ø> (ø)

... and 1425 files with indirect coverage changes

Copy link

@sanderegg sanderegg merged commit 5396bda into ITISFoundation:master Aug 30, 2024
1 check passed
@sanderegg sanderegg deleted the traefik-v3/cors branch August 30, 2024 06:54
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx good luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants