Skip to content

🎨 improve tip e2e test #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Sep 25, 2024

What do these changes do?

  • 🎨 improve tip e2e test
    • Our end-to-end tests are waiting to verify whether all progress bars report 100%.
    • This is not always the case (I’ve spent some time investigating, but I don’t know the reason yet).
    • Nevertheless, the frontend doesn't care. Once everything is ready and downloaded, the service starts. Therefore, I modified the test so that, in cases where 100% is not achieved, it will still proceed to the next step, just as the frontend would.

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Sep 25, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review September 25, 2024 14:21
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.0%. Comparing base (cafbf96) to head (d564912).
Report is 588 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6448      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.4%     
=========================================
  Files          10    1526    +1516     
  Lines         214   62778   +62564     
  Branches       25    2029    +2004     
=========================================
+ Hits          181   55291   +55110     
- Misses         23    7174    +7151     
- Partials       10     313     +303     
Flag Coverage Δ
integrationtests 63.3% <ø> (?)
unittests 86.2% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1476 files with indirect coverage changes

@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Sep 25, 2024
@matusdrobuliak66 matusdrobuliak66 added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels Sep 25, 2024
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tldr lgtm as discussed 🥇

@pcrespov pcrespov disabled auto-merge September 25, 2024 18:52
@pcrespov pcrespov merged commit 2889c20 into ITISFoundation:master Sep 25, 2024
1 of 2 checks passed
Copy link

@matusdrobuliak66 matusdrobuliak66 deleted the maintenance/fix-tip-test branch September 26, 2024 07:37
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 2, 2024
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 29, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants