-
Notifications
You must be signed in to change notification settings - Fork 29
🎨 improve tip e2e test #6448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 improve tip e2e test #6448
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6448 +/- ##
=========================================
+ Coverage 84.5% 88.0% +3.4%
=========================================
Files 10 1526 +1516
Lines 214 62778 +62564
Branches 25 2029 +2004
=========================================
+ Hits 181 55291 +55110
- Misses 23 7174 +7151
- Partials 10 313 +303
Flags with carried forward coverage won't be shown. Click here to find out more. |
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
packages/pytest-simcore/src/pytest_simcore/helpers/playwright.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tldr lgtm as discussed 🥇
|
What do these changes do?
Related issue/s
How to test
Dev-ops checklist