🎨 EFS Guardian adding data removal background task

[matusdrobuliak66]

What do these changes do?

• 🎨 EFS Guardian adding data removal background task
• Improvements:
  • ♻️ Refactor unit tests in Efs Guardian service
  • ♻️ Extend faker_projects_data with project_data fixture -> continue in the same logic as faker_{payments/products/users}
  • ♻️ Refactor project lock -> move common function to servicelib

Related issue/s

• relates Filesystem - Large File Handling (Caching) #6411

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 66.44295% with 50 lines in your changes missing coverage. Please review.

Project coverage is 88.0%. Comparing base (cafbf96) to head (3b74cfb).
Report is 658 commits behind head on master.

Files with missing lines	Patch %	Lines
...ges/service-library/src/servicelib/project_lock.py	0.0%	35 Missing ⚠️
...mcore_service_efs_guardian/services/efs_manager.py	61.2%	12 Missing ⚠️
..._service_efs_guardian/services/background_tasks.py	91.3%	2 Missing ⚠️
...imcore_service_efs_guardian/services/modules/db.py	90.9%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #6562      +/-   ##
=========================================
+ Coverage    84.5%   88.0%    +3.4%     
=========================================
  Files          10    1556    +1546     
  Lines         214   63674   +63460     
  Branches       25    2085    +2060     
=========================================
+ Hits          181   56061   +55880     
- Misses         23    7296    +7273     
- Partials       10     317     +307     

Flag	Coverage Δ
integrationtests	64.7% <100.0%> (?)
unittests	86.0% <66.4%> (+1.4%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...odels-library/src/models_library/projects_state.py	98.4% <100.0%> (ø)
...se/src/simcore_postgres_database/utils_projects.py	100.0% <100.0%> (ø)
...c/simcore_service_efs_guardian/core/application.py	94.8% <100.0%> (ø)
.../src/simcore_service_efs_guardian/core/settings.py	100.0% <100.0%> (ø)
...ce_efs_guardian/services/background_tasks_setup.py	75.6% <100.0%> (ø)
...c/simcore_service_webserver/projects/exceptions.py	94.9% <100.0%> (ø)
...ver/src/simcore_service_webserver/projects/lock.py	100.0% <100.0%> (ø)
...imcore_service_efs_guardian/services/modules/db.py	90.9% <90.9%> (ø)
..._service_efs_guardian/services/background_tasks.py	93.3% <91.3%> (ø)
...mcore_service_efs_guardian/services/efs_manager.py	82.0% <61.2%> (ø)
... and 1 more

... and 1494 files with indirect coverage changes

[pcrespov]

Nice. I left some suggestions

I learned that this PR

• sets up pg in efsg
• adds listing of project uuids in efsg manager
• implements removal_policy_task
• updates (nicely) all tests

[sanderegg]

not sure I get why you replace fakeredis with the real redis. it is slower to startup. there are a few comments that I left. Thanks a lot!

[sanderegg]

thanks!

[pcrespov]

🎉 thx!

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud