-
Notifications
You must be signed in to change notification settings - Fork 29
🐛Dynamic schldr: deferred tasks passing invalid kwargs parameters to exceptions #6573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Dynamic schldr: deferred tasks passing invalid kwargs parameters to exceptions #6573
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6573 +/- ##
=========================================
+ Coverage 84.5% 88.9% +4.3%
=========================================
Files 10 1425 +1415
Lines 214 58832 +58618
Branches 25 1392 +1367
=========================================
+ Hits 181 52341 +52160
- Misses 23 6292 +6269
- Partials 10 199 +189
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🙌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THX!
What do these changes do?
The dynamic-scheduler is not setting the log level correctly ->
DYNAMIC_SCHEDULER_LOGLEVEL
is now properly setup.Also Graylog was broken because of an error that was retried an incredible amount of times and the error led to huge amounts of logs being sent there.
among other the validation of log level was fixed repo-wide. the validator is a pre-validator not a post-validator.
Corrected some elements of language.
Related issue/s
How to test
Dev-ops checklist