Skip to content

🐛Dynamic schldr: deferred tasks passing invalid kwargs parameters to exceptions #6573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 22, 2024

What do these changes do?

The dynamic-scheduler is not setting the log level correctly -> DYNAMIC_SCHEDULER_LOGLEVEL is now properly setup.
Also Graylog was broken because of an error that was retried an incredible amount of times and the error led to huge amounts of logs being sent there.

among other the validation of log level was fixed repo-wide. the validator is a pre-validator not a post-validator.

Corrected some elements of language.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:infra+ops maintenance of infrastructure or operations (discussed in retro) a:dynamic-sidecar dynamic-sidecar service labels Oct 22, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 22, 2024
@sanderegg sanderegg self-assigned this Oct 22, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.9%. Comparing base (cafbf96) to head (a46c633).
Report is 660 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6573      +/-   ##
=========================================
+ Coverage    84.5%   88.9%    +4.3%     
=========================================
  Files          10    1425    +1415     
  Lines         214   58832   +58618     
  Branches       25    1392    +1367     
=========================================
+ Hits          181   52341   +52160     
- Misses         23    6292    +6269     
- Partials       10     199     +189     
Flag Coverage Δ
integrationtests 64.7% <100.0%> (?)
unittests 86.7% <100.0%> (+2.2%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...g/src/simcore_service_autoscaling/core/settings.py 100.0% <100.0%> (ø)
...c/simcore_service_clusters_keeper/core/settings.py 100.0% <100.0%> (ø)
...simcore_service_dynamic_scheduler/core/settings.py 100.0% <100.0%> (ø)
...uler/src/simcore_service_dynamic_scheduler/main.py 100.0% <100.0%> (ø)
...c/simcore_service_dynamic_sidecar/core/settings.py 97.2% <100.0%> (ø)
.../src/simcore_service_efs_guardian/core/settings.py 100.0% <100.0%> (ø)
...s/src/simcore_service_invitations/core/settings.py 97.4% <100.0%> (ø)
...ents/src/simcore_service_payments/core/settings.py 100.0% <100.0%> (ø)
...re_service_resource_usage_tracker/core/settings.py 100.0% <100.0%> (ø)
.../simcore_service_webserver/application_settings.py 99.4% <100.0%> (ø)

... and 1364 files with indirect coverage changes

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

Copy link

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX!

@sanderegg sanderegg merged commit 682d4fa into ITISFoundation:master Oct 22, 2024
52 of 53 checks passed
@sanderegg sanderegg deleted the dynamic-schldr/fixes branch October 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants