Skip to content

♻️ tracing can be disabled on all services #6682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 7, 2024

⚠️ devops

  • no changes required

What do these changes do?

Expose the configuration to disable the opentelemetry to all the services that are currently using it.

Extra:

  • disabled tracing on autoscaling's unittests

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (927319c) to head (4c8ea64).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6682      +/-   ##
==========================================
+ Coverage   87.66%   87.94%   +0.27%     
==========================================
  Files        1527     1557      +30     
  Lines       60858    62790    +1932     
  Branches     2106     2106              
==========================================
+ Hits        53352    55220    +1868     
- Misses       7181     7245      +64     
  Partials      325      325              
Flag Coverage Δ
integrationtests 64.85% <ø> (+0.03%) ⬆️
unittests 85.90% <ø> (+0.35%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.38% <ø> (ø)
pkg_dask_task_models_library 96.87% <ø> (ø)
pkg_models_library 92.19% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.77% <ø> (ø)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library 76.53% <ø> (ø)
pkg_settings_library 91.42% <ø> (ø)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.21% <ø> (∅)
catalog 89.46% <ø> (-0.07%) ⬇️
clusters_keeper 98.72% <ø> (-0.13%) ⬇️
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.80% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.59% <ø> (-0.14%) ⬇️
dynamic_sidecar 89.79% <ø> (ø)
efs_guardian 90.00% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 93.02% <ø> (-0.07%) ⬇️
resource_usage_tracker 90.75% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927319c...4c8ea64. Read the comment docs.

@GitHK GitHK self-assigned this Nov 7, 2024
@GitHK GitHK added bug buggy, it does not work as expected t:maintenance Some planned maintenance work labels Nov 7, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 7, 2024
@GitHK GitHK marked this pull request as ready for review November 7, 2024 10:27
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@GitHK GitHK requested a review from pcrespov as a code owner November 7, 2024 11:34
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this was the step missing ... htx @GitHK

@GitHK GitHK enabled auto-merge (squash) November 8, 2024 05:22
@GitHK GitHK disabled auto-merge November 8, 2024 05:24
@GitHK GitHK enabled auto-merge (squash) November 8, 2024 05:34
Copy link

sonarqubecloud bot commented Nov 8, 2024

@GitHK GitHK merged commit 72766b4 into ITISFoundation:master Nov 8, 2024
84 of 89 checks passed
@GitHK GitHK deleted the pr-osparc-fix-opentelemetry-settings branch November 8, 2024 08:10
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants