Skip to content

🐛 fix uvicorn logs that were always on INFO #7045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 fix uvicorn logs that were always on INFO (they did not respect the LOGLEVEL of specific service)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review January 15, 2025 13:10
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jan 15, 2025
@matusdrobuliak66 matusdrobuliak66 added the bug buggy, it does not work as expected label Jan 15, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Jan 15, 2025
Copy link

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking all of them

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (a63e747) to head (3fd2c71).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a63e747) and HEAD (3fd2c71). Click for more details.

HEAD has 24 uploads less than BASE
Flag BASE (a63e747) HEAD (3fd2c71)
unittests 31 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7045       +/-   ##
===========================================
- Coverage   86.82%   71.95%   -14.88%     
===========================================
  Files        1651      895      -756     
  Lines       64839    40357    -24482     
  Branches     2043      262     -1781     
===========================================
- Hits        56299    29039    -27260     
- Misses       8205    11258     +3053     
+ Partials      335       60      -275     
Flag Coverage Δ *Carryforward flag
integrationtests 63.45% <ø> (ø) Carriedforward from a63e747
unittests 94.06% <ø> (+9.08%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling 96.09% <ø> (ø)
catalog ∅ <ø> (∅)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.59% <ø> (-12.73%) ⬇️
dynamic_scheduler 97.20% <ø> (ø)
dynamic_sidecar 89.59% <ø> (-0.16%) ⬇️
efs_guardian 90.46% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.52% <ø> (+0.23%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 57.62% <ø> (-26.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63e747...3fd2c71. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the evil copy&pasting. thx

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 15, 2025 16:10
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matusdrobuliak66 matusdrobuliak66 merged commit 5a3ea20 into ITISFoundation:master Jan 15, 2025
88 of 92 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants