Skip to content

🎨E2E: add --service_version option #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 24, 2025

What do these changes do?

adds the option to define the service version for sim4life and jupyterlabs in E2E tests

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Jan 24, 2025
@sanderegg sanderegg added this to the Singularity milestone Jan 24, 2025
@sanderegg sanderegg self-assigned this Jan 24, 2025
Copy link

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.96%. Comparing base (2415e78) to head (d405a39).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7083      +/-   ##
==========================================
- Coverage   87.38%   86.96%   -0.43%     
==========================================
  Files        1693     1490     -203     
  Lines       65873    58059    -7814     
  Branches     1121      711     -410     
==========================================
- Hits        57563    50489    -7074     
+ Misses       7990     7377     -613     
+ Partials      320      193     -127     
Flag Coverage Δ *Carryforward flag
integrationtests 65.51% <ø> (+0.04%) ⬆️
unittests 85.94% <ø> (-0.61%) ⬇️ Carriedforward from 2415e78

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 94.24% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.63% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.28% <ø> (ø)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.61% <ø> (ø)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.10% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.44% <ø> (+0.17%) ⬆️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.00% <ø> (ø)
storage 86.58% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 81.14% <ø> (-4.66%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2415e78...d405a39. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the e2e/test-specific-version branch from 9e00fcc to c3e70fc Compare February 26, 2025 15:39
@sanderegg sanderegg modified the milestones: Singularity, The Awakening Mar 6, 2025
@sanderegg sanderegg force-pushed the e2e/test-specific-version branch from c3e70fc to 1e7fd65 Compare March 7, 2025 09:15
@sanderegg sanderegg force-pushed the e2e/test-specific-version branch from 1e7fd65 to d405a39 Compare March 7, 2025 12:49
@sanderegg sanderegg marked this pull request as ready for review March 7, 2025 12:49
Copy link

sonarqubecloud bot commented Mar 7, 2025

@sanderegg sanderegg merged commit 6160bad into ITISFoundation:master Mar 7, 2025
94 of 95 checks passed
@sanderegg sanderegg deleted the e2e/test-specific-version branch March 7, 2025 14:23
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E: Add a test for pre-Vulkan sim4life
3 participants