♻️Storage: Code refactoring prior to changes (🚨🚨) #7088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:storage
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7088 +/- ##
==========================================
+ Coverage 87.27% 87.76% +0.48%
==========================================
Files 1641 1628 -13
Lines 64222 63226 -996
Branches 1179 1093 -86
==========================================
- Hits 56051 55488 -563
+ Misses 7860 7426 -434
- Partials 311 312 +1
Continue to review full report in Codecov by Sentry.
|
sanderegg
force-pushed
the
storage/refactoring
branch
6 times, most recently
from
2eaa872 to
dd968f9
Compare
21 tasks
sanderegg
force-pushed
the
storage/refactoring
branch
2 times, most recently
from
65be5bc to
2c7fcea
Compare
sanderegg
requested review from
pcrespov,
GitHK,
matusdrobuliak66 and
giancarloromeo
as code owners
sanderegg
changed the title
GitHK
reviewed
Jan 30, 2025
giancarloromeo
approved these changes
Jan 30, 2025
GitHK
reviewed
Jan 30, 2025
packages/service-library/src/servicelib/fastapi/long_running_tasks/client.py
Show resolved
Hide resolved
GitHK
reviewed
Jan 30, 2025
GitHK
reviewed
Jan 30, 2025
GitHK
reviewed
Jan 30, 2025
GitHK
reviewed
Jan 30, 2025
GitHK
reviewed
Jan 30, 2025
services/storage/tests/unit/test__legacy_storage_sdk_compatibility.py
Outdated
Show resolved
Hide resolved
pcrespov
reviewed
Jan 30, 2025
sanderegg
force-pushed
the
storage/refactoring
branch
from
0ba5783 to
c1b135c
Compare
|
|
@Mergifyio queue |
❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚. |
🛑 The pull request has been merged manuallyThe pull request has been merged manually at 3bb98a6 |
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Very noisy PR that refactors storage service from aiohttp- to fastapi-based service.
Important note: @bisgaard-itis @GitHK @mrnicegyu11 @odeimaiz @matusdrobuliak66 storage cannot be run as several replicas as I could not find a way to get the IP of the server via call to request during uploads of files. That means this will need a subsequent PR that will keep the state of the upload in the DB or call into AWS S3 until the completion of the S3 multipart is done. There will be a follow up on that in 1 week.
Related issue/s
storage#6887 by removing aiohttpHow to test
Dev-ops checklist