Skip to content

🐛 fix licensed items listing with hidden flag #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Feb 14, 2025

What do these changes do?

  • 🐛 fix licensed items listing with hidden flag

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 14, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 14, 2025 16:00
@matusdrobuliak66 matusdrobuliak66 added bug buggy, it does not work as expected a:webserver issue related to the webserver service labels Feb 14, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Singularity milestone Feb 14, 2025
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 14, 2025 16:01
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.50%. Comparing base (73eff71) to head (4889535).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7232      +/-   ##
==========================================
- Coverage   87.00%   83.50%   -3.50%     
==========================================
  Files        1667      647    -1020     
  Lines       64721    31246   -33475     
  Branches     1096      168     -928     
==========================================
- Hits        56309    26093   -30216     
+ Misses       8099     5095    -3004     
+ Partials      313       58     -255     
Flag Coverage Δ
integrationtests 65.31% <0.00%> (-0.06%) ⬇️
unittests 85.79% <50.00%> (-0.21%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.31% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.66% <ø> (-12.65%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.77% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 84.76% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73eff71...4889535. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 17, 2025 07:54
@matusdrobuliak66 matusdrobuliak66 merged commit bcaa959 into ITISFoundation:master Feb 17, 2025
91 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants