Skip to content

WIP: ♻️ Mai/project renaming #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 64 commits into from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Feb 17, 2025

What do these changes do?

  • projects domain skeleton
  • projects coverage >90%

Related issue/s

How to test

Dev-ops

None

@pcrespov pcrespov added a:webserver issue related to the webserver service t:maintenance Some planned maintenance work labels Feb 17, 2025
@pcrespov pcrespov self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 53.35599% with 549 lines in your changes missing coverage. Please review.

Project coverage is 81.49%. Comparing base (dfb4149) to head (298e9c5).
Report is 19 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (dfb4149) and HEAD (298e9c5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (dfb4149) HEAD (298e9c5)
unittests 30 28
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7240      +/-   ##
==========================================
- Coverage   87.23%   81.49%   -5.75%     
==========================================
  Files        1705     1652      -53     
  Lines       66228    63671    -2557     
  Branches     1124     1124              
==========================================
- Hits        57776    51890    -5886     
- Misses       8132    11461    +3329     
  Partials      320      320              
Flag Coverage Δ
integrationtests 59.85% <52.18%> (ø)
unittests 89.35% <40.10%> (-0.04%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <100.00%> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 ∅ <ø> (∅)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.28% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 41.89% <52.95%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb4149...298e9c5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov force-pushed the mai/project-renaming branch 3 times, most recently from f3becf4 to 13bfc1e Compare February 18, 2025 23:03
@pcrespov pcrespov modified the milestones: Singularity, The Awakening Feb 19, 2025
@pcrespov pcrespov force-pushed the mai/project-renaming branch from 13bfc1e to 5aebfda Compare February 26, 2025 13:44
@pcrespov pcrespov force-pushed the mai/project-renaming branch from 7ba8f8e to 482f107 Compare March 7, 2025 17:15
Copy link

@pcrespov
Copy link
Member Author

I do not trust merging. we would have to start again. keep the structure though

@pcrespov pcrespov closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant