-
Notifications
You must be signed in to change notification settings - Fork 29
🎨 add num_of_seats
to pricing unit (for LICENSE type pricing plan)
#7271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 add num_of_seats
to pricing unit (for LICENSE type pricing plan)
#7271
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7271 +/- ##
==========================================
- Coverage 87.11% 86.93% -0.19%
==========================================
Files 1685 1511 -174
Lines 65437 61511 -3926
Branches 1115 889 -226
==========================================
- Hits 57007 53473 -3534
+ Misses 8115 7781 -334
+ Partials 315 257 -58
Continue to review full report in Codecov by Sentry.
|
num_of_seats
to pricing unit (for LICENSE type pricing plan)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.!
packages/models-library/src/models_library/api_schemas_resource_usage_tracker/pricing_plans.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/errors.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/licenses/errors.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
packages/models-library/src/models_library/api_schemas_resource_usage_tracker/pricing_plans.py
Show resolved
Hide resolved
packages/models-library/src/models_library/api_schemas_resource_usage_tracker/pricing_plans.py
Show resolved
Hide resolved
…buliak66/osparc-simcore into vip-models-fix-pricing-units-v2
|
2472861
into
ITISFoundation:master
What do these changes do?
Story
TIER
), which was used for billing running services and simulations.CPU
,RAM
, andVRAM
.LICENSE
).num_of_seats
field in the unit’s extra info.Highlights
services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py
, the new field is used to validate the body parameters sent by the frontend.num_of_seats
field is now passed to the frontend client. (Until now, the frontend was extracting this value from the display name.)Related issue/s
How to test
Dev-ops checklist