Skip to content

🎨 add num_of_seats to pricing unit (for LICENSE type pricing plan) #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Feb 25, 2025

What do these changes do?

Story

  • Previously, we only had one type of pricing plan (CLASSIFICATION=TIER), which was used for billing running services and simulations.
  • This pricing plan used a pricing unit with required extra info fields: CPU, RAM, and VRAM.
  • Now, we have introduced a new type of pricing plan (CLASSIFICATION=LICENSE).
  • This new pricing plan also uses pricing units, but their purpose is to store the number of seats offered. Therefore, we need the num_of_seats field in the unit’s extra info.

Highlights

  • In services/web/server/src/simcore_service_webserver/licenses/_licensed_items_service.py, the new field is used to validate the body parameters sent by the frontend.
  • The num_of_seats field is now passed to the frontend client. (Until now, the frontend was extracting this value from the display name.)

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 60.55046% with 43 lines in your changes missing coverage. Please review.

Project coverage is 86.93%. Comparing base (cdabc90) to head (36b41a5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7271      +/-   ##
==========================================
- Coverage   87.11%   86.93%   -0.19%     
==========================================
  Files        1685     1511     -174     
  Lines       65437    61511    -3926     
  Branches     1115      889     -226     
==========================================
- Hits        57007    53473    -3534     
+ Misses       8115     7781     -334     
+ Partials      315      257      -58     
Flag Coverage Δ
integrationtests 65.41% <27.90%> (+0.01%) ⬆️
unittests 85.88% <60.55%> (-0.26%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.54% <71.42%> (-0.13%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.03% <ø> (ø)
pkg_service_library 72.52% <0.00%> (-0.06%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.56% <100.00%> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.73% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.06% <ø> (ø)
director 76.59% <ø> (ø)
director_v2 91.30% <100.00%> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 89.74% <ø> (ø)
efs_guardian 90.25% <ø> (ø)
invitations 93.28% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.22% <100.00%> (+0.14%) ⬆️
storage 84.49% <ø> (+0.24%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.11% <63.41%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdabc90...36b41a5. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 self-assigned this Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the The Awakening milestone Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title 🎨 add num of seats to pricing unit for LICENSE plan 🎨 add num_of_seats to pricing unit (for LICENSE type pricing plan) Feb 25, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review February 25, 2025 14:58
@matusdrobuliak66 matusdrobuliak66 added a:webserver issue related to the webserver service a:resource-usage-tracker resource usage tracker service labels Feb 25, 2025
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) February 26, 2025 10:43
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 2472861 into ITISFoundation:master Feb 26, 2025
89 of 95 checks passed
sanderegg pushed a commit to sanderegg/osparc-simcore that referenced this pull request Feb 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Mar 6, 2025
63 tasks
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:resource-usage-tracker resource usage tracker service a:webserver issue related to the webserver service
Projects
None yet
5 participants