-
Notifications
You must be signed in to change notification settings - Fork 28
✨ web-api: Adds endpoint to retrieve project services with Release and Access Information #7287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ web-api: Adds endpoint to retrieve project services with Release and Access Information #7287
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7287 +/- ##
==========================================
+ Coverage 86.78% 87.18% +0.40%
==========================================
Files 1518 1693 +175
Lines 60431 65772 +5341
Branches 884 1121 +237
==========================================
+ Hits 52445 57344 +4899
- Misses 7719 8108 +389
- Partials 267 320 +53
Continue to review full report in Codecov by Sentry.
|
05afcdd
to
b371f1e
Compare
74e57f1
to
43ae5b0
Compare
batch-get
services
batch-get
servicesbatch-get
services
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/services.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a bit of a mess with the review comments. sorry for that.
services/catalog/src/simcore_service_catalog/api/rpc/_services.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! hoping this makes it fast!
I am not convinced by replacing list
by batch_get
I find the first one much more clear. but whatever.
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/errors.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/catalog/services.py
Show resolved
Hide resolved
@sanderegg I think there is a misunderstanding.The design change isn't just about replacing the service list with batch-get. The core idea is to fetch only what’s needed, when it’s needed. Before: All service details were included in the service listing. In any case, none of this will have a real effect until the logic in the front-end is modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks :)
6868c13
to
6b02ba2
Compare
|
…d Access Information (ITISFoundation#7287)
What do these changes do?
The objective is to introduce an end-point in the web API that, given a project, retrieves all its services along with release and access-rights information. This would enable the front-end to:
✨
web-server
osparc service:GET /projects/{project_id}/nodes/-/services
in projects rest controller✨
catalog
osparc service:New batch-get operation for services:
batch_get_my_services
.Deprecation of the
history
field in service listings:history
field is now marked as deprecated in service listings.Next steps
history
field from services listingRelated issue/s
How to test
Driving tests
Manual testing
Dev-ops
None