-
Notifications
You must be signed in to change notification settings - Fork 29
🐛 Fixes raises when stopping log fetching in dynamic-sidecar
#7302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes raises when stopping log fetching in dynamic-sidecar
#7302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/docker_logs.py
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7302 +/- ##
===========================================
- Coverage 87.19% 67.68% -19.51%
===========================================
Files 1693 658 -1035
Lines 65772 31491 -34281
Branches 1121 168 -953
===========================================
- Hits 57347 21315 -36032
- Misses 8105 10118 +2013
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
…oundation#7302) Co-authored-by: Andrei Neagu <[email protected]>
What do these changes do?
Sometimes the docker engine will raise TimeoutError when awaiting the log fetching task in the background. These can be safely ignore and avoids errors when soothing down the user services.
Related issue/s
How to test
Dev-ops checklist