Skip to content

🐛 Fixes raises when stopping log fetching in dynamic-sidecar #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 4, 2025

What do these changes do?

Sometimes the docker engine will raise TimeoutError when awaiting the log fetching task in the background. These can be safely ignore and avoids errors when soothing down the user services.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Mar 4, 2025
@GitHK GitHK added bug buggy, it does not work as expected a:dynamic-sidecar dynamic-sidecar service labels Mar 4, 2025
@GitHK GitHK added this to the The Awakening milestone Mar 4, 2025
@GitHK GitHK marked this pull request as ready for review March 4, 2025 09:27
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.68%. Comparing base (daf0b6a) to head (2693629).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (daf0b6a) and HEAD (2693629). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (daf0b6a) HEAD (2693629)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7302       +/-   ##
===========================================
- Coverage   87.19%   67.68%   -19.51%     
===========================================
  Files        1693      658     -1035     
  Lines       65772    31491    -34281     
  Branches     1121      168      -953     
===========================================
- Hits        57347    21315    -36032     
- Misses       8105    10118     +2013     
+ Partials      320       58      -262     
Flag Coverage Δ
integrationtests 65.36% <66.66%> (-0.01%) ⬇️
unittests 89.21% <100.00%> (+2.86%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.50% <ø> (-12.80%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 90.28% <100.00%> (+<0.01%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.37% <ø> (-25.95%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daf0b6a...2693629. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK GitHK enabled auto-merge (squash) March 6, 2025 10:06
GitHK

This comment was marked as off-topic.

GitHK

This comment was marked as off-topic.

Copy link

sonarqubecloud bot commented Mar 6, 2025

@GitHK GitHK merged commit a4a3bc3 into ITISFoundation:master Mar 6, 2025
91 of 95 checks passed
@GitHK GitHK deleted the pr-osparc-fix-stop-log-fetching branch March 6, 2025 10:59
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-sidecar dynamic-sidecar service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic-sidecar times out and raises occasionally error when calling stop_log_fetching
4 participants