-
Notifications
You must be signed in to change notification settings - Fork 28
🐛 Clean Pydantic model_dump
s warnings
#7358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Clean Pydantic model_dump
s warnings
#7358
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7358 +/- ##
==========================================
+ Coverage 87.41% 88.80% +1.39%
==========================================
Files 1729 1386 -343
Lines 66864 57085 -9779
Branches 1133 481 -652
==========================================
- Hits 58449 50696 -7753
+ Misses 8094 6257 -1837
+ Partials 321 132 -189
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the description of the PR is incomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this ready for review or not?
|
What do these changes do?
Clean warnings on
director-v2
integration tests, also seen on production.Cause
The
StandardSimcoreDockerLabels
object is created using.model_construct
and thenode_id
was astr
instead ofUUID
.Related issue/s
How to test
Dev-ops checklist