-
Notifications
You must be signed in to change notification settings - Fork 28
🎨Storage: HA (🚨🚨🚨 test with multiple replicas) #7375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Storage: HA (🚨🚨🚨 test with multiple replicas) #7375
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7375 +/- ##
==========================================
+ Coverage 87.43% 88.03% +0.60%
==========================================
Files 1719 1337 -382
Lines 66692 55309 -11383
Branches 1132 586 -546
==========================================
- Hits 58310 48692 -9618
+ Misses 8061 6431 -1630
+ Partials 321 186 -135
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
fa6d169
to
7a87169
Compare
7a87169
to
2977870
Compare
9cc4ae8
to
78adcad
Compare
016cdec
to
709f4d0
Compare
Since storage can be replicated, we make number of its replicas configurable via ENV Related PR: ITISFoundation/osparc-simcore#7375
Related to #5621 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🙏 Very much appreciated 🎉
Please, once this is deployed, merge changes in OPS (including related config changes). Or just let me know, I will do it 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Have 1 question
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/modules/celery/client.py
Outdated
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/modules/celery/client.py
Outdated
Show resolved
Hide resolved
f501664
to
02d1fee
Compare
This reverts commit e680984.
38d6642
to
3907cf9
Compare
|
Since storage can be replicated, we make number of its replicas configurable via ENV Related PR: ITISFoundation/osparc-simcore#7375
What do these changes do?
This PR shall unlock having multiple replicas of storage micro-service by:
POST /simcore-s3/folders
is gone)test_rpc_handlers_paths
Bonus:
Related issue/s
How to test
Dev-ops checklist