🎨 web-api: patch userName at least 4 chars ⚠️

[pcrespov]

What do these changes do?

• 🎨 web-api 0.61.1 → 0.61.2: Enforces a minimum length of 4 characters for userName in the PATCH entrypoint, restricting front-end inputs to names longer than 3 characters.
• ♻️ Refactors model tests: moves schema-related tests to models-library, while retaining tests covering domain-schema interactions in web-server.
• 🎨 Users upon creation enforces also minimum lengh constraint: utils_user._generate_username_from_email

Related issue/s

• Resolves https://github.com/ITISFoundation/private-issues/issues/33

How to test

cd packages/models-library
make install-dev
pytest tests/test_api_schemas_webserver_users.py

Dev-ops

• ⚠️ Review and update db users.name upon deploys. SEE 🎨 web-api: patch userName at least 4 chars ⚠️ #7389 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.62%. Comparing base (45ffe4e) to head (dfda292).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7389      +/-   ##
==========================================
+ Coverage   85.65%   88.62%   +2.96%     
==========================================
  Files        1709     1473     -236     
  Lines       66355    58787    -7568     
  Branches     1124      615     -509     
==========================================
- Hits        56838    52098    -4740     
+ Misses       9195     6518    -2677     
+ Partials      322      171     -151     

Flag	Coverage Δ
integrationtests	65.26% <0.00%> (-0.03%)	⬇️
unittests	87.70% <80.00%> (+3.09%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	92.01% <100.00%> (+0.26%)	⬆️
pkg_notifications_library	84.57% <ø> (ø)
pkg_postgres_database	88.11% <100.00%> (+0.03%)	⬆️
pkg_service_integration	70.03% <ø> (ø)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.46% <ø> (ø)
agent	96.46% <ø> (ø)
api_server	90.68% <ø> (ø)
autoscaling	96.08% <ø> (ø)
catalog	92.14% <ø> (ø)
clusters_keeper	99.24% <ø> (ø)
dask_sidecar	91.25% <ø> (ø)
datcore_adapter	98.11% <ø> (ø)
director	76.59% <ø> (ø)
director_v2	91.30% <ø> (ø)
dynamic_scheduler	97.33% <ø> (ø)
dynamic_sidecar	90.11% <ø> (ø)
efs_guardian	89.79% <ø> (ø)
invitations	93.28% <ø> (ø)
payments	92.66% <ø> (ø)
resource_usage_tracker	89.12% <ø> (ø)
storage	84.18% <ø> (-0.36%)	⬇️
webclient	∅ <ø> (∅)
webserver	85.80% <0.00%> (+5.48%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ffe4e...dfda292. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[odeimaiz]

thx_

[odeimaiz]

There are a few existing usernames with only 2 or 3 characters, we might need to update them when we deploy this.

[pcrespov]

There are a few existing usernames with only 2 or 3 characters, we might need to update them when we deploy this.

@odeimaiz we can do so but just FYI in principle this PR only constraints the patch API. i.e. having these username in the database is still allowed because the ProfileGet does not validate that

[odeimaiz]

There are a few existing usernames with only 2 or 3 characters, we might need to update them when we deploy this.

@odeimaiz we can do so but just FYI in principle this PR only constraints the patch API. i.e. having these username in the database is still allowed because the ProfileGet does not validate that

Sure, but as discussed, these users would never be searchable

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud