-
Notifications
You must be signed in to change notification settings - Fork 28
⚗️Director-v0: Disable keep-alive connections #7405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️Director-v0: Disable keep-alive connections #7405
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7405 +/- ##
==========================================
- Coverage 87.31% 87.08% -0.23%
==========================================
Files 1712 1343 -369
Lines 66429 56024 -10405
Branches 1125 578 -547
==========================================
- Hits 58004 48790 -9214
+ Misses 8105 7049 -1056
+ Partials 320 185 -135
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8944b1f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
What do these changes do?
After observing the registry is oddly loaded, we try to disable the Keep-alive connections in the httpx client. This way load-balancing via docker swarm shall not be impaired.
Related issue/s
How to test
Dev-ops checklist