-
Notifications
You must be signed in to change notification settings - Fork 28
✨Async Jobs: add some tests + an internal client #7410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Async Jobs: add some tests + an internal client #7410
Conversation
864fabe
to
5b2d357
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7410 +/- ##
==========================================
- Coverage 87.31% 87.14% -0.17%
==========================================
Files 1712 1343 -369
Lines 66430 56101 -10329
Branches 1125 584 -541
==========================================
- Hits 58004 48890 -9114
+ Misses 8106 7024 -1082
+ Partials 320 187 -133
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot for the effort!
Left some suggestions and questions, mainly for my understanding.
services/storage/src/simcore_service_storage/modules/celery/_celery_types.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
packages/service-library/tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
|
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the clarifications and the effort
What do these changes do?
Related issue/s
How to test
Dev-ops checklist