Skip to content

✨Async Jobs: add some tests + an internal client #7410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2025

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 21, 2025

What do these changes do?

  • introduces a client for calling async jobs via RPC (same as with long running tasks)
  • adds some tests
  • add some fixes for celery task in case of coroutines
  • added example (THAT WILL BE USED IN THE NEXT PR) of using pydantic types in celery tasks

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:services-library issues on packages/service-libs label Mar 21, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 21, 2025
@sanderegg sanderegg self-assigned this Mar 21, 2025
@sanderegg sanderegg force-pushed the async-jobs-enhancements branch from 864fabe to 5b2d357 Compare March 21, 2025 14:09
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 88.37209% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (180355d) to head (6b928bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7410      +/-   ##
==========================================
- Coverage   87.31%   87.14%   -0.17%     
==========================================
  Files        1712     1343     -369     
  Lines       66430    56101   -10329     
  Branches     1125      584     -541     
==========================================
- Hits        58004    48890    -9114     
+ Misses       8106     7024    -1082     
+ Partials      320      187     -133     
Flag Coverage Δ
integrationtests 65.30% <ø> (+0.02%) ⬆️
unittests 86.14% <88.37%> (-0.33%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.84% <92.72%> (+0.60%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.70% <ø> (ø)
director_v2 91.25% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.18% <ø> (+0.05%) ⬆️
storage 84.55% <80.64%> (+0.15%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.86% <ø> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 180355d...6b928bc. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot for the effort!
Left some suggestions and questions, mainly for my understanding.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the clarifications and the effort

@sanderegg sanderegg enabled auto-merge (squash) March 24, 2025 08:45
@sanderegg sanderegg merged commit 445c6de into ITISFoundation:master Mar 24, 2025
145 of 146 checks passed
@sanderegg sanderegg deleted the async-jobs-enhancements branch March 24, 2025 08:51
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants