Skip to content

🎨🐛 [Frontend] Enh/fix: Services Pricing Plans #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 24, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 24, 2025

What do these changes do?

requested by @mguidon

When listing the services assigned to a pricing plan, if for whatever reason the service:version isn't available to the user, the list will not be printed. This PR fixes this issue by printing the valid services and showing the invalid ones in a Flash Message.

Services

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Mar 24, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 24, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 24, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 24, 2025 13:18
@odeimaiz odeimaiz requested a review from mguidon March 24, 2025 13:20
@odeimaiz odeimaiz changed the title 🎨🐛 [Frontend] Enh: Services Pricing Plans 🎨🐛 [Frontend] Enh/fix: Services Pricing Plans Mar 24, 2025
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 24, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Mar 24, 2025

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = deploy to dockerhub
        • check-skipped = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
        • check-success = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-neutral = integration-tests
        • check-skipped = integration-tests
        • check-success = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link
Contributor

mergify bot commented Mar 24, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@odeimaiz odeimaiz merged commit 4a3c8fe into ITISFoundation:master Mar 24, 2025
57 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants