Skip to content

🐛web-api: Fixes missing supportID on default 5XX responses #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2025

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 24, 2025

What do these changes do?

Fixes missing supportID on default 5XX responses from the web-api:

image

Related issue/s

How to test

cd packages/service-library
make "install-dev[aiohttp]"
pytest -vv tests/aiohttp -k tests_exception_to_response

Dev-ops

None

@pcrespov pcrespov self-assigned this Mar 24, 2025
@pcrespov pcrespov added a:webserver issue related to the webserver service a:services-library issues on packages/service-libs labels Mar 24, 2025
@pcrespov pcrespov added this to the The Awakening milestone Mar 24, 2025
@pcrespov pcrespov requested review from odeimaiz, sanderegg and GitHK and removed request for odeimaiz and sanderegg March 24, 2025 13:06
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov enabled auto-merge (squash) March 24, 2025 13:10
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (81c58df) to head (97d332e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7414      +/-   ##
==========================================
- Coverage   87.36%   87.16%   -0.21%     
==========================================
  Files        1712     1343     -369     
  Lines       66513    56103   -10410     
  Branches     1131      584     -547     
==========================================
- Hits        58112    48901    -9211     
+ Misses       8079     7015    -1064     
+ Partials      322      187     -135     
Flag Coverage Δ
integrationtests 65.26% <ø> (-0.07%) ⬇️
unittests 86.18% <100.00%> (-0.36%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 73.01% <100.00%> (+0.16%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.68% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.14% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.61% <ø> (-0.19%) ⬇️
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 84.67% <ø> (+0.11%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.85% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81c58df...97d332e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov requested a review from bisgaard-itis March 24, 2025 14:31
@pcrespov pcrespov merged commit 0a16428 into ITISFoundation:master Mar 24, 2025
94 checks passed
@pcrespov pcrespov deleted the is7362/enh-support-id branch March 24, 2025 14:56
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:services-library issues on packages/service-libs a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants