-
Notifications
You must be signed in to change notification settings - Fork 28
🎨 web-api: empty_trash
operation waits until explicitly trashed projects are deleted
#7416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 web-api: empty_trash
operation waits until explicitly trashed projects are deleted
#7416
Conversation
empty_trash
operation waits until explicitly trashed projects are deleted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7416 +/- ##
==========================================
- Coverage 86.00% 84.03% -1.98%
==========================================
Files 1638 663 -975
Lines 63240 31722 -31518
Branches 1131 168 -963
==========================================
- Hits 54390 26656 -27734
+ Misses 8528 5008 -3520
+ Partials 322 58 -264
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
d1ae9ab
to
ce4245a
Compare
ce4245a
to
3771a5e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are OK with it. It's fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can try that. but it looks like a sleep in disguise.
if you have really a big load and the webserver is somehow under the water, that call will take more or less long to respond.
What do these changes do?
POST /trash:empty
now triggers a fire&forget task but ensures that explicitly trashed projects are deleted before responding. This prevents trashed items from still appearing in the list right after the operation, avoiding confusion on the front-end.This is a compromise between:
NOTE to reviewers: Heuristically, this approach has worked well for me. Nonetheless, if it proves insufficient, we can fall back to option 1 (and then the front-end needs to handle it if it times out).
Related issue/s
How to test
in place
Dev-ops