Skip to content

🎨 [Frontend] Enh: Wording and .po file #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 25, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Mar 25, 2025

What do these changes do?

In this PR the en.po file generated at compilation time is added to the repository. This po file contains all the strings (the ones that are marked for translation: qx.locale.Manager.tr(str)) the frontend shows to the user.

This po file, together with our messages guidelines, was passed to an AI and it proposed some changes.

As proof of concept of how the po files work in the animation you can see what happens when one changes the locale. For the demo, I generated and populated the en and de locale po files:
Locales

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Mar 25, 2025
@odeimaiz odeimaiz added this to the The Awakening milestone Mar 25, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Mar 25, 2025
@odeimaiz odeimaiz marked this pull request as ready for review March 25, 2025 14:32
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Enh: .po file 🎨 [Frontend] Enh: Wording and .po file Mar 25, 2025
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 25, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Mar 25, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

  • I took the liberty to link with the issue i had opened for the backend
  • why not add some translation (e.g. in Chinese) as a proof-of-concept? Can be flagged as in dev mode only

Copy link

@odeimaiz odeimaiz removed the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 25, 2025
@odeimaiz odeimaiz merged commit 938c1da into ITISFoundation:master Mar 25, 2025
57 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants