Skip to content

🐛 Fix redis ssl certificate issue #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bisgaard-itis
Copy link
Contributor

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Mar 25, 2025
@bisgaard-itis bisgaard-itis added the bug buggy, it does not work as expected label Mar 25, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great. will push it

@sanderegg sanderegg merged commit 7b26c6f into ITISFoundation:master Mar 25, 2025
3 of 4 checks passed
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (4d91e4a) to head (99bee98).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4d91e4a) and HEAD (99bee98). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (4d91e4a) HEAD (99bee98)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7425       +/-   ##
===========================================
- Coverage   85.69%   68.67%   -17.02%     
===========================================
  Files        1714      725      -989     
  Lines       66594    34322    -32272     
  Branches     1131      168      -963     
===========================================
- Hits        57068    23572    -33496     
- Misses       9204    10692     +1488     
+ Partials      322       58      -264     
Flag Coverage Δ
integrationtests 65.17% <ø> (-0.01%) ⬇️
unittests 84.53% <50.00%> (-0.12%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.58% <ø> (-12.72%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 84.53% <50.00%> (+0.04%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.11% <ø> (-21.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d91e4a...99bee98. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis deleted the only-use-ssl-certs-when-rediss branch March 25, 2025 14:49
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants