Skip to content

🐛Storage Worker does not need a RabbitMQ client #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 25, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added bug buggy, it does not work as expected a:storage issue related to storage service labels Mar 25, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 25, 2025
@sanderegg sanderegg self-assigned this Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.65%. Comparing base (38ae3c0) to head (866b34b).
Report is 6 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (38ae3c0) and HEAD (866b34b). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (38ae3c0) HEAD (866b34b)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7426       +/-   ##
===========================================
- Coverage   87.33%   68.65%   -18.68%     
===========================================
  Files        1714      725      -989     
  Lines       66592    34314    -32278     
  Branches     1131      168      -963     
===========================================
- Hits        58155    23559    -34596     
- Misses       8115    10697     +2582     
+ Partials      322       58      -264     
Flag Coverage Δ
integrationtests 65.14% <ø> (+<0.01%) ⬆️
unittests 84.52% <100.00%> (-1.98%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (-12.74%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 84.52% <100.00%> (+0.04%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.09% <ø> (-26.63%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ae3c0...866b34b. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg force-pushed the storage-worker/does-not-need-rabbit-rpc-or-so branch from 866b34b to 302072a Compare March 25, 2025 17:05
@sanderegg sanderegg merged commit cdff4c5 into ITISFoundation:master Mar 25, 2025
3 of 4 checks passed
@sanderegg sanderegg deleted the storage-worker/does-not-need-rabbit-rpc-or-so branch March 25, 2025 17:06
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Mar 26, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:storage issue related to storage service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant