-
Notifications
You must be signed in to change notification settings - Fork 28
✨ Start implementation of programs
section of api server
#7447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Start implementation of programs
section of api server
#7447
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7447 +/- ##
==========================================
+ Coverage 87.41% 88.90% +1.49%
==========================================
Files 1737 1200 -537
Lines 67039 50931 -16108
Branches 1138 170 -968
==========================================
- Hits 58601 45280 -13321
+ Misses 8117 5593 -2524
+ Partials 321 58 -263
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx.
Ok let's move forward but we need to put together a bit more "love" into the api-server...
services/api-server/src/simcore_service_api_server/models/schemas/programs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/programs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/programs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/programs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/programs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/programs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/_utils.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/models/schemas/jobs.py
Outdated
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services_http/catalog.py
Show resolved
Hide resolved
services/api-server/src/simcore_service_api_server/services_http/catalog.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarifications. Looking forward for the renaming PR that comes afterwards.
packages/simcore-sdk/src/simcore_sdk/node_ports_common/filemanager.py
Outdated
Show resolved
Hide resolved
|
What do these changes do?
programs
section to api-server's REST api:POST /v0/files/content
endpoint (that's the endpoint for getting upload links when performing a multipart upload to osparc) to allow uploading files directly into a program job.Related issue/s
How to test
Dev-ops checklist