Skip to content

✨ Start implementation of programs section of api server #7447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Mar 28, 2025

What do these changes do?

ReDoc

  • Add programs section to api-server's REST api:
    image
  • This is done by refactoring the already existing endpoints for managing solver jobs.
  • A program is an osparc project containing a single node with a dynamic service. With the current implementation it is not possible to add inputs to a program job, but the projects workspace directly is created via the api-server so that the user can directly upload files into the workspace.
  • Update the API-server's POST /v0/files/content endpoint (that's the endpoint for getting upload links when performing a multipart upload to osparc) to allow uploading files directly into a program job.
    image

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 79.30029% with 71 lines in your changes missing coverage. Please review.

Project coverage is 88.90%. Comparing base (2d2d69e) to head (07f6285).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7447      +/-   ##
==========================================
+ Coverage   87.41%   88.90%   +1.49%     
==========================================
  Files        1737     1200     -537     
  Lines       67039    50931   -16108     
  Branches     1138      170     -968     
==========================================
- Hits        58601    45280   -13321     
+ Misses       8117     5593    -2524     
+ Partials      321       58     -263     
Flag Coverage Δ
integrationtests 65.24% <33.33%> (+0.02%) ⬆️
unittests 87.85% <79.30%> (+1.25%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.40% <33.33%> (-0.06%) ⬇️
agent 96.46% <ø> (ø)
api_server 90.02% <79.70%> (-0.81%) ⬇️
autoscaling 96.08% <ø> (ø)
catalog 91.82% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.27% <ø> (-0.03%) ⬇️
dynamic_scheduler 97.35% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (+0.32%) ⬆️
storage 87.21% <ø> (+0.03%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.97% <ø> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d2d69e...07f6285. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis self-assigned this Mar 31, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.
Ok let's move forward but we need to put together a bit more "love" into the api-server...

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications. Looking forward for the renaming PR that comes afterwards.

Copy link

sonarqubecloud bot commented Apr 8, 2025

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) April 8, 2025 11:38
@bisgaard-itis bisgaard-itis merged commit 70409d2 into ITISFoundation:master Apr 8, 2025
89 of 94 checks passed
@bisgaard-itis bisgaard-itis deleted the 1870-start-program-section-of-api-server branch April 8, 2025 12:10
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:apiserver api-server service t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants