Skip to content

🎨Director-v0: set default timeout to 20s and potentially allow setting it up #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 31, 2025

What do these changes do?

  • adds DIRECTOR_REGISTRY_CLIENT_TIMEOUT as a potential ENV variable. default value is now set to 20 seconds to be similar with old aiohttp client

If this really needs to become a fully fledged ENV, let me know @mrnicegyu11

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director issue related with the director service label Mar 31, 2025
@sanderegg sanderegg added this to the The Awakening milestone Mar 31, 2025
@sanderegg sanderegg requested a review from mrnicegyu11 March 31, 2025 16:19
@sanderegg sanderegg self-assigned this Mar 31, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Mar 31, 2025
@sanderegg sanderegg marked this pull request as ready for review March 31, 2025 16:20
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (3a4bf81) to head (50d1f48).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7460      +/-   ##
==========================================
- Coverage   87.41%   87.19%   -0.23%     
==========================================
  Files        1728     1359     -369     
  Lines       66812    56391   -10421     
  Branches     1133      586     -547     
==========================================
- Hits        58404    49170    -9234     
+ Misses       8087     7035    -1052     
+ Partials      321      186     -135     
Flag Coverage Δ
integrationtests 65.18% <ø> (-0.01%) ⬇️
unittests 86.20% <81.81%> (-0.39%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.47% <0.00%> (-0.02%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.46% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 90.73% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 91.82% <ø> (ø)
clusters_keeper 99.24% <ø> (ø)
dask_sidecar 91.25% <ø> (ø)
datcore_adapter 98.11% <ø> (ø)
director 76.78% <100.00%> (+0.16%) ⬆️
director_v2 91.30% <ø> (ø)
dynamic_scheduler 97.33% <ø> (ø)
dynamic_sidecar 90.11% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.29% <ø> (+0.16%) ⬆️
storage 86.65% <ø> (+0.03%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.85% <ø> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a4bf81...50d1f48. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg requested a review from YuryHrytsuk March 31, 2025 16:25
@sanderegg sanderegg linked an issue Mar 31, 2025 that may be closed by this pull request
1 task
@mrnicegyu11
Copy link
Member

Thanks!

@sanderegg sanderegg merged commit f09b9c2 into ITISFoundation:master Apr 1, 2025
94 checks passed
@sanderegg sanderegg deleted the director-v0/add-env-variables-for-timeouts branch April 1, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director issue related with the director service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Httpx timeout in director-v0 bug
4 participants