-
Notifications
You must be signed in to change notification settings - Fork 28
🎨Director-v0: set default timeout to 20s and potentially allow setting it up #7460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨Director-v0: set default timeout to 20s and potentially allow setting it up #7460
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7460 +/- ##
==========================================
- Coverage 87.41% 87.19% -0.23%
==========================================
Files 1728 1359 -369
Lines 66812 56391 -10421
Branches 1133 586 -547
==========================================
- Hits 58404 49170 -9234
+ Misses 8087 7035 -1052
+ Partials 321 186 -135
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Thanks! |
What do these changes do?
DIRECTOR_REGISTRY_CLIENT_TIMEOUT
as a potential ENV variable. default value is now set to 20 seconds to be similar with old aiohttp clientIf this really needs to become a fully fledged ENV, let me know @mrnicegyu11
Related issue/s
How to test
Dev-ops checklist