-
Notifications
You must be signed in to change notification settings - Fork 29
🐛Dask-sidecar: set 1 hour timeout when waiting for container logs #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Dask-sidecar: set 1 hour timeout when waiting for container logs #7472
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7472 +/- ##
===========================================
- Coverage 87.41% 67.88% -19.53%
===========================================
Files 1737 687 -1050
Lines 67029 32608 -34421
Branches 1138 168 -970
===========================================
- Hits 58591 22136 -36455
- Misses 8117 10414 +2297
+ Partials 321 58 -263
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
services/dask-sidecar/src/simcore_service_dask_sidecar/computational_sidecar/docker_utils.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
45798cd
to
4410146
Compare
@mergify queue |
🟠 Waiting for conditions to match
|
|
What do these changes do?
When a container does not throw any logs for 5 minutes, aiodocker throw a TimeoutError as it is based on aiohttp.
This PR changes that timeout to 1 hour.
Related issue/s
How to test
Dev-ops checklist