Skip to content

🐛Dask-sidecar: set 1 hour timeout when waiting for container logs #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 3, 2025

What do these changes do?

When a container does not throw any logs for 5 minutes, aiodocker throw a TimeoutError as it is based on aiohttp.
This PR changes that timeout to 1 hour.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added bug buggy, it does not work as expected a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels Apr 3, 2025
@sanderegg sanderegg added this to the The Awakening milestone Apr 3, 2025
@sanderegg sanderegg self-assigned this Apr 3, 2025
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.88%. Comparing base (1959875) to head (4410146).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1959875) and HEAD (4410146). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (1959875) HEAD (4410146)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7472       +/-   ##
===========================================
- Coverage   87.41%   67.88%   -19.53%     
===========================================
  Files        1737      687     -1050     
  Lines       67029    32608    -34421     
  Branches     1138      168      -970     
===========================================
- Hits        58591    22136    -36455     
- Misses       8117    10414     +2297     
+ Partials      321       58      -263     
Flag Coverage Δ
integrationtests 65.12% <ø> (-0.05%) ⬇️
unittests 91.29% <100.00%> (+4.70%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar 91.29% <100.00%> (+0.03%) ⬆️
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.55% <ø> (-12.75%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.09% <ø> (-26.84%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1959875...4410146. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Apr 3, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sanderegg sanderegg force-pushed the dask-sidecar/bugfixes/set-1-hour-timeout branch from 45798cd to 4410146 Compare April 3, 2025 20:12
@sanderegg
Copy link
Member Author

@mergify queue

Copy link
Contributor

mergify bot commented Apr 3, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

Copy link

sonarqubecloud bot commented Apr 3, 2025

@sanderegg sanderegg merged commit ef99643 into ITISFoundation:master Apr 3, 2025
91 of 94 checks passed
@sanderegg sanderegg deleted the dask-sidecar/bugfixes/set-1-hour-timeout branch April 3, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker bug buggy, it does not work as expected t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants