Skip to content

🐛Webserver: duplication of studies, ensure message does not contain progress #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 3, 2025

What do these changes do?

Revert message as it was before arrival of storage HA.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Apr 3, 2025
@sanderegg sanderegg added this to the The Awakening milestone Apr 3, 2025
@sanderegg sanderegg self-assigned this Apr 3, 2025
Copy link

sonarqubecloud bot commented Apr 3, 2025

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (4aedb35) to head (7a9f237).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4aedb35) and HEAD (7a9f237). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (4aedb35) HEAD (7a9f237)
unittests 31 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7474      +/-   ##
==========================================
- Coverage   87.40%   80.80%   -6.61%     
==========================================
  Files        1737      673    -1064     
  Lines       67029    31850   -35179     
  Branches     1138      168     -970     
==========================================
- Hits        58590    25736   -32854     
+ Misses       8118     6056    -2062     
+ Partials      321       58     -263     
Flag Coverage Δ
integrationtests 65.17% <ø> (+0.04%) ⬆️
unittests 81.02% <ø> (-5.57%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.58% <ø> (-12.72%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 80.55% <ø> (-5.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aedb35...7a9f237. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 1959875 into ITISFoundation:master Apr 3, 2025
88 of 94 checks passed
@sanderegg sanderegg deleted the webserver/duplication-fix-message branch April 3, 2025 18:19
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants