-
Notifications
You must be signed in to change notification settings - Fork 28
🐛🎨 [Frontend] Handle missing services #7488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛🎨 [Frontend] Handle missing services #7488
Conversation
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1aecd75 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you give some insight on "the call fails"? Is it a failure due to invalid service metadata? Is it a sporadic failure of the http call? The entrypoint is faulty and fails frequently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a backend problem here. or at least some errors not converted back correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it's a backend issue (that we myst fix) to me it makes sense to have this in. Provides a better use experience overall.
|
What do these changes do?
Since the frontend doesn't know about the entire history of all services, it relies on what the backend tells it about the services in a study.
I found a corner case where according to the
study/services
endpoint all services are fine, but when trying to fetch the service metadata the call fails.This PR handles this scenario by blocking the card and not letting users open the study.
Fixed:

Related issue/s
How to test
Dev-ops checklist