Skip to content

🐛🎨 [Frontend] Handle missing services #7488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Apr 10, 2025

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 8, 2025

What do these changes do?

Since the frontend doesn't know about the entire history of all services, it relies on what the backend tells it about the services in a study.

I found a corner case where according to the study/services endpoint all services are fine, but when trying to fetch the service metadata the call fails.

This PR handles this scenario by blocking the card and not letting users open the study.

Fixed:
BlockStudy

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Apr 8, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 8, 2025
@odeimaiz odeimaiz added this to the Pauwel Kwak milestone Apr 8, 2025
@odeimaiz odeimaiz marked this pull request as ready for review April 9, 2025 09:29
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Handle missing services 🐛🎨 [Frontend] Handle missing services Apr 9, 2025
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 9, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 9, 2025

@Mergifyio queue

Copy link
Contributor

mergify bot commented Apr 9, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1aecd75

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some insight on "the call fails"? Is it a failure due to invalid service metadata? Is it a sporadic failure of the http call? The entrypoint is faulty and fails frequently?

@odeimaiz
Copy link
Member Author

odeimaiz commented Apr 9, 2025

Can you give some insight on "the call fails"? Is it a failure due to invalid service metadata? Is it a sporadic failure of the http call? The entrypoint is faulty and fails frequently?

I get a 500, and I can see this in the catalog:
image

@odeimaiz odeimaiz removed the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 9, 2025
@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 9, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a backend problem here. or at least some errors not converted back correctly

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's a backend issue (that we myst fix) to me it makes sense to have this in. Provides a better use experience overall.

@mergify mergify bot merged commit 1aecd75 into ITISFoundation:master Apr 10, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants