-
Notifications
You must be signed in to change notification settings - Fork 28
♻️ export data feature enhancements #7498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ export data feature enhancements #7498
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7498 +/- ##
===========================================
- Coverage 87.44% 69.03% -18.41%
===========================================
Files 1741 739 -1002
Lines 67359 34610 -32749
Branches 1142 170 -972
===========================================
- Hits 58900 23894 -35006
- Misses 8139 10658 +2519
+ Partials 320 58 -262
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
services/storage/src/simcore_service_storage/utils/simcore_s3_dsm_utils.py
Outdated
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/utils/simcore_s3_dsm_utils.py
Outdated
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/utils/simcore_s3_dsm_utils.py
Outdated
Show resolved
Hide resolved
…export-selection-by-path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand why the storage service must take care of this restriction. Added a few comments.
services/storage/src/simcore_service_storage/exceptions/errors.py
Outdated
Show resolved
Hide resolved
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b253cb0 |
|
What do these changes do?
/some/selection/in/the/bucket/file/
will add onlyfile
inside the archive.Related issue/s
How to test
Dev-ops checklist