-
Notifications
You must be signed in to change notification settings - Fork 29
🎨 replace project_id and node_id with appropriate labels when exporting #7508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 replace project_id and node_id with appropriate labels when exporting #7508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7508 +/- ##
===========================================
- Coverage 87.59% 68.93% -18.67%
===========================================
Files 1752 746 -1006
Lines 67846 34940 -32906
Branches 1121 170 -951
===========================================
- Hits 59429 24085 -35344
- Misses 8109 10797 +2688
+ Partials 308 58 -250
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering why you did not re-use the function that is already around?
services/storage/src/simcore_service_storage/utils/simcore_s3_dsm_utils.py
Show resolved
Hide resolved
services/storage/src/simcore_service_storage/utils/simcore_s3_dsm_utils.py
Outdated
Show resolved
Hide resolved
…-project-and-node-in-exports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed. thanks!
…-project-and-node-in-exports
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 96bf18b |
|
What do these changes do?
When exporting data,
project_id
is replaced with the project's name whilenode_id
is replaced with the node's label.Also, special character
/
is escaped with_
.Related issue/s
How to test
Dev-ops checklist