🎨 Add program unit tests #7524
Closed
🎨 Add program unit tests #7524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7524 +/- ##
==========================================
+ Coverage 87.44% 87.51% +0.07%
==========================================
Files 1740 1733 -7
Lines 67389 67199 -190
Branches 1143 1143
==========================================
- Hits 58931 58812 -119
+ Misses 8138 8067 -71
Partials 320 320
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
pcrespov
approved these changes
Apr 15, 2025
| @@ -499,7 +499,7 @@ def _patch(href): | |||
| return data.status_href, data.result_href | |||
|
|
|||
| return mocker.patch( | |||
| "simcore_service_api_server.services.webserver._get_lrt_urls", | |||
| "simcore_service_api_server.services_http.webserver._get_lrt_urls", | |||
There was a problem hiding this comment.
TIP: to avoid these it is better if you import the module and then patch the object. It is more resistant to refactoring. Also add auto_spec=True to enhance validity of your mock
import simcore_service_api_server.services_http.webserver
mocker.patch.object(simcore_service_api_server.services_http.webserver,._get_lrt_urls", auto_spec=True, side_effect=_get_lrt_urls)| ) | ||
| async def test_create_program_job( | ||
| client: AsyncClient, | ||
| mocked_webserver_rest_api_base, |
|
These tests have been added here instead (using the new catalog client): #7541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops checklist