🐛 Generate API base URL by active product ⚠️ #7619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giancarloromeo
added
a:webserver
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #7619 +/- ##
==========================================
- Coverage 87.66% 87.61% -0.06%
==========================================
Files 1794 1806 +12
Lines 69341 69686 +345
Branches 1136 1190 +54
==========================================
+ Hits 60790 61054 +264
- Misses 8241 8307 +66
- Partials 310 325 +15
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the API base URL generation by replacing hardcoded values with dynamically constructed URLs based on the request's forwarded host information. It also centralizes host extraction logic via a new generator function and adds tests to verify the correct URL format.
- Updates API key creation flow to generate the correct base URL.
- Introduces the iter_originating_hosts helper for consistent host extraction.
- Adds unit tests to validate the new API base URL behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/web/server/tests/unit/with_dbs/01/test_api_keys.py | Updated test to verify new API base URL generation with the forwarded host header. |
| services/web/server/src/simcore_service_webserver/utils_aiohttp.py | Added the iter_originating_hosts generator to streamline host extraction. |
| services/web/server/src/simcore_service_webserver/utils.py | Introduced is_ip_address to assist in host validation. |
| services/web/server/src/simcore_service_webserver/products/_web_middlewares.py | Replaced manual host lookup with iter_originating_hosts for consistency. |
| services/web/server/src/simcore_service_webserver/api_keys/_controller/rest.py | Updated _get_api_base_url to build the API URL dynamically and removed the hardcoded URL. |
giancarloromeo
requested review from
pcrespov,
sanderegg,
GitHK and
matusdrobuliak66
as code owners
pcrespov
approved these changes
May 14, 2025
services/web/server/src/simcore_service_webserver/api_keys/_controller/rest.py
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
May 14, 2025
...simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_user_services.py
Outdated
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/osparc_variables/substitutions.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/utils_aiohttp.py
Outdated
Show resolved
Hide resolved
giancarloromeo
added
🤖-automerge
giancarloromeo
commented
May 14, 2025
giancarloromeo
added
🤖-automerge
|
@Mergifyio: Queue |
|
YuryHrytsuk
approved these changes
May 14, 2025
mrnicegyu11
approved these changes
May 14, 2025
Sure, that's enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This pull request fixes the API base URL generation by replacing hardcoded values with dynamically constructed URLs based on the request's forwarded host information. It also centralizes host extraction logic via a new generator function and adds tests to verify the correct URL format.
iter_originshelper for consistent host extraction.Related issue/s
How to test
Dev-ops
Remove DIRECTOR_V2_PUBLIC_API_BASE_URL env vars