Skip to content

✨Maintenance CLI: introduce option to terminate dynamic instances #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 5, 2025

What do these changes do?

This pull request introduces a new feature to terminate dynamic instances.
image

New Feature: Terminate Dynamic Instances

  • Added a new CLI command terminate_dynamic_instances in cli.py to allow termination of instances by user ID or instance ID, with an optional force flag for bypassing confirmation.
  • Implemented the terminate_dynamic_instances function in core.py, which validates inputs, retrieves matching instances, and handles termination with user confirmation or forced execution.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label May 5, 2025
@sanderegg sanderegg added this to the Pauwel Kwak milestone May 5, 2025
@sanderegg sanderegg self-assigned this May 5, 2025
@sanderegg sanderegg force-pushed the maintenance/cli-to-terminate-instances branch from e76a19a to bc93db5 Compare May 5, 2025 09:54
@sanderegg sanderegg modified the milestones: Pauwel Kwak, Pirulo May 5, 2025
@sanderegg sanderegg marked this pull request as ready for review May 5, 2025 11:44
@sanderegg sanderegg force-pushed the maintenance/cli-to-terminate-instances branch from 0f4c4ec to a16e9ef Compare May 5, 2025 11:44
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg merged commit a8f88d6 into ITISFoundation:master May 5, 2025
14 checks passed
@sanderegg sanderegg deleted the maintenance/cli-to-terminate-instances branch May 5, 2025 13:32
Copy link

sonarqubecloud bot commented May 5, 2025

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants