-
Notifications
You must be signed in to change notification settings - Fork 29
♻️Director-v2: removed aiopg dependency also from tests #7638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Director-v2: removed aiopg dependency also from tests #7638
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7638 +/- ##
==========================================
+ Coverage 87.72% 87.76% +0.03%
==========================================
Files 1788 1781 -7
Lines 68979 68789 -190
Branches 1134 1134
==========================================
- Hits 60515 60374 -141
+ Misses 8152 8103 -49
Partials 312 312
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What do these changes do?
This PR definitely removes aiopg dependency from dv-2, even from tests requirements.
Also adds a warning in the
aiopg_engine
fixture in pytest-simcore.Related issue/s
How to test
Dev-ops