Skip to content

🎨 add WAITING_FOR_RESOURCES to get_pipeline_state_from_task_states #7640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented May 6, 2025

What do these changes do?

  • 🎨 add WAITING_FOR_RESOURCES to get_pipeline_state_from_task_states --> fixing: if task was in state WAITING_FOR_RESOURCES it was reported as ERROR in the Comp runs

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone May 6, 2025
@matusdrobuliak66 matusdrobuliak66 self-assigned this May 6, 2025
@matusdrobuliak66 matusdrobuliak66 added a:director-v2 issue related with the director-v2 service computational clusters labels May 6, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 6, 2025 09:11
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why is this required?

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.91%. Comparing base (4bd14ca) to head (547cbcb).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4bd14ca) and HEAD (547cbcb). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (4bd14ca) HEAD (547cbcb)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7640       +/-   ##
===========================================
- Coverage   87.75%   69.91%   -17.84%     
===========================================
  Files        1788      692     -1096     
  Lines       68979    32523    -36456     
  Branches     1134      170      -964     
===========================================
- Hits        60530    22740    -37790     
- Misses       8138     9725     +1587     
+ Partials      311       58      -253     
Flag Coverage Δ
integrationtests 64.95% <ø> (-0.01%) ⬇️
unittests 84.48% <ø> (-2.48%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (-8.43%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.08% <ø> (-0.03%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.06% <ø> (-1.10%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.13% <ø> (-26.95%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bd14ca...547cbcb. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66
Copy link
Collaborator Author

Q: why is this required?

because it is missing. if task is in state WAITING_FOR_RESOURCES it is reported as ERROR in the RUNs

@matusdrobuliak66 matusdrobuliak66 requested a review from GitHK May 6, 2025 09:22
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add your comment to the description of the PR, the reason for the change was not clear to me

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed

Copy link

sonarqubecloud bot commented May 6, 2025

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 6, 2025 12:18
@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label May 6, 2025
@matusdrobuliak66 matusdrobuliak66 merged commit 1168c77 into ITISFoundation:master May 6, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖-automerge marks PR as ready to be merged for Mergify a:director-v2 issue related with the director-v2 service computational clusters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants