-
Notifications
You must be signed in to change notification settings - Fork 29
✨ Add exemplars to prometheus metrics #7644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add exemplars to prometheus metrics #7644
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7644 +/- ##
==========================================
- Coverage 87.51% 87.22% -0.30%
==========================================
Files 1811 1427 -384
Lines 70308 59370 -10938
Branches 1143 604 -539
==========================================
- Hits 61533 51787 -9746
+ Misses 8462 7398 -1064
+ Partials 313 185 -128
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks please consider my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in thinking that you removed the fastapi-instrumentation library usage?
If yes should you not also remove its dependency?
…:bisgaard-itis/osparc-simcore into 7635-add-exemplars-to-prometheus-metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to consolidate the aiohttp and fastapi middleware we use to collect prometheus metrics.
What does it mean? This is not clear
Before we used our own custom implementation middleware for collecting prometheus metrics for aiohttp services and a pip installed tool for fastapi services. Now I have removed that tool and refactored the aiohttp middleware to have an aiohttp middleware and a separate fastapi middleware (custom implementation) which call the same module for collecting prometheus metrics |
tests have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I would like to ask you some specific details about it sometime offline
|
What do these changes do?
Related issue/s
How to test
Dev-ops