✨ [Frontend] Templates and Public Projects in Study Browser #7676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
giancarloromeo,
GitHK,
pcrespov,
sanderegg,
matusdrobuliak66 and
Copilot
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds Templates and Public Projects sections to the Study Browser by introducing new store methods, UI contexts, and renaming the existing TemplateBrowser to TutorialBrowser for consistency.
- Added paginated fetch methods for templates in
osparc.store.Templates - Extended StudyBrowser context and filter components to support
templatesandpublic - Renamed TemplateBrowser to TutorialBrowser and updated related Dashboard, MainPage, and filter code
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Templates.js | Added fetchTemplatesPaginated and alias for public templates |
| services/static-webserver/client/source/class/osparc/store/Store.js | Extended studyBrowserContext enum with templates and public |
| services/static-webserver/client/source/class/osparc/jobs/RunsTable.js | Extracted cancel-run logic to __cancelRun and updated listener |
| services/static-webserver/client/source/class/osparc/info/ServiceLarge.js | Refactored thumbnail min/max bound calculations |
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Updated pipeline submission callback signature |
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Switched TemplateBrowser references to TutorialBrowser |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Added getPageSorted endpoint for templates |
| services/static-webserver/client/source/class/osparc/data/Job.js | Updated job status labels |
| services/static-webserver/client/source/class/osparc/dashboard/TutorialBrowser.js | Renamed TemplateBrowser class to TutorialBrowser |
| services/static-webserver/client/source/class/osparc/dashboard/StudyBrowserHeader.js | Added icons and titles for templates and public contexts |
| services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js | Integrated template/public fetching into StudyBrowser |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceContainerManager.js | Adjusted workspace/folder container visibility toggles |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js | Added filter buttons for templates and public contexts |
| services/static-webserver/client/source/class/osparc/dashboard/NewPlusMenu.js | Renamed "Services..." menu button label to "Apps..." |
| services/static-webserver/client/source/class/osparc/dashboard/Dashboard.js | Replaced TemplateBrowser tab with TutorialBrowser |
Files not reviewed (1)
- services/static-webserver/client/source/translation/en.po: Language not supported
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserFilter.js:153
- [nitpick] In the public projects listener, the variable
templatesEnabledis misleading. Rename it to something likepublicEnabledfor clarity.
const templatesEnabled = e.getData();
services/static-webserver/client/source/class/osparc/dashboard/Dashboard.js:226
- [nitpick] The local variable
templatesViewis misleading in the__createTutorialBrowsermethod. Consider renaming it totutorialViewfor consistency.
const templatesView = this.__tutorialBrowser = new osparc.dashboard.TutorialBrowser();
services/static-webserver/client/source/class/osparc/jobs/RunsTable.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/info/ServiceLarge.js
Show resolved
Hide resolved
…Table.js Co-authored-by: Copilot <[email protected]>
…iceLarge.js Co-authored-by: Copilot <[email protected]>
…imaiz/osparc-simcore into feature/templates-in-project-browser
|
pcrespov
reviewed
May 15, 2025
Not sure I get the question. Pagination was already being used. The problem with the templates is that some widgets rely on the templates (TIP plus buttons), and in order to populate them all templates were required. My plan is to mark them as Tutorials, and therefore only all Tutorials will be required. |
…imaiz/osparc-simcore into feature/templates-in-project-browser
pcrespov
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds the Templates and Public Projects sections to the StudyBrowser. Here the paginated templates will be listed.
Related issue/s
How to test
Dev-ops