-
Notifications
You must be signed in to change notification settings - Fork 29
π¨ add project template type π¨ (ποΈ) #7677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π¨ add project template type π¨ (ποΈ) #7677
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7677 +/- ##
==========================================
+ Coverage 87.56% 87.57% +0.01%
==========================================
Files 1802 1795 -7
Lines 70119 69950 -169
Branches 1137 1137
==========================================
- Hits 61399 61262 -137
+ Misses 8410 8378 -32
Partials 310 310
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
services/web/server/tests/integration/01/test_garbage_collection.py
Outdated
Show resolved
Hide resolved
...ces/web/server/tests/unit/with_dbs/04/studies_dispatcher/test_studies_dispatcher_projects.py
Outdated
Show resolved
Hide resolved
...b/server/tests/unit/with_dbs/04/studies_dispatcher/test_studies_dispatcher_studies_access.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Merci!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, only the question about why creating a separate type. anyway thanks!
packages/postgres-database/src/simcore_postgres_database/models/projects.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. Left some comments
packages/models-library/src/models_library/api_schemas_webserver/projects.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects.py
Show resolved
Hide resolved
β¦liak66/osparc-simcore into add-template-type-to-projects
|
What do these changes do?
NEXT steps:
Related issue/s
How to test
Dev-ops