Skip to content

🎨 add project template type 🚨 (πŸ—ƒοΈ) #7677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented May 14, 2025

What do these changes do?

  • 🎨 Add project type and template type to project REST resource
class ProjectTemplateType(StrAutoEnum):
    TEMPLATE = auto()
    TUTORIAL = auto()
    HYPERTOOL = auto()
  • πŸ—ƒοΈ Add template type to a database
  • NOTE: There was no effort to refactor or improve anything related to the Project module in this PR; all legacy code was still reused.

NEXT steps:

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 14, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone May 14, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: add project template type WIP: add project template type (πŸ—ƒοΈ) May 14, 2025
Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.57%. Comparing base (81958f3) to head (1729ed5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7677      +/-   ##
==========================================
+ Coverage   87.56%   87.57%   +0.01%     
==========================================
  Files        1802     1795       -7     
  Lines       70119    69950     -169     
  Branches     1137     1137              
==========================================
- Hits        61399    61262     -137     
+ Misses       8410     8378      -32     
  Partials      310      310              
Flag Coverage Ξ”
integrationtests 64.43% <76.92%> (-0.03%) ⬇️
unittests 86.80% <96.55%> (+0.01%) ⬆️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library 93.92% <ΓΈ> (ΓΈ)
pkg_dask_task_models_library 98.48% <ΓΈ> (ΓΈ)
pkg_models_library 93.07% <100.00%> (+0.01%) ⬆️
pkg_notifications_library 85.26% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.58% <100.00%> (+0.02%) ⬆️
pkg_service_integration 69.92% <ΓΈ> (ΓΈ)
pkg_service_library 72.02% <ΓΈ> (ΓΈ)
pkg_settings_library 90.90% <ΓΈ> (ΓΈ)
pkg_simcore_sdk 85.54% <ΓΈ> (+0.05%) ⬆️
agent 96.46% <ΓΈ> (ΓΈ)
api_server 91.52% <ΓΈ> (ΓΈ)
autoscaling 96.08% <ΓΈ> (ΓΈ)
catalog 92.64% <ΓΈ> (ΓΈ)
clusters_keeper 99.25% <ΓΈ> (ΓΈ)
dask_sidecar 89.88% <ΓΈ> (ΓΈ)
datcore_adapter 98.12% <ΓΈ> (ΓΈ)
director 76.80% <ΓΈ> (ΓΈ)
director_v2 91.18% <ΓΈ> (ΓΈ)
dynamic_scheduler 96.76% <ΓΈ> (ΓΈ)
dynamic_sidecar 90.15% <ΓΈ> (ΓΈ)
efs_guardian 89.79% <ΓΈ> (ΓΈ)
invitations 93.28% <ΓΈ> (ΓΈ)
payments 92.63% <ΓΈ> (ΓΈ)
resource_usage_tracker 89.02% <ΓΈ> (ΓΈ)
storage 87.49% <ΓΈ> (ΓΈ)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 85.81% <92.30%> (-0.06%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 81958f3...1729ed5. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: add project template type (πŸ—ƒοΈ) WIP: add project template type 🚨 (πŸ—ƒοΈ) May 15, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title WIP: add project template type 🚨 (πŸ—ƒοΈ) 🎨 add project template type 🚨 (πŸ—ƒοΈ) May 15, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 15, 2025 07:04
@matusdrobuliak66 matusdrobuliak66 requested a review from odeimaiz May 15, 2025 07:04
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label May 15, 2025
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Merci!

@matusdrobuliak66 matusdrobuliak66 requested a review from GitHK May 15, 2025 07:32
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, only the question about why creating a separate type. anyway thanks!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Left some comments

@matusdrobuliak66 matusdrobuliak66 requested a review from pcrespov May 15, 2025 11:19
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 15, 2025 12:35
@matusdrobuliak66 matusdrobuliak66 added the πŸ€–-automerge marks PR as ready to be merged for Mergify label May 15, 2025
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 50a4875 into ITISFoundation:master May 15, 2025
95 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the add-template-type-to-projects branch May 15, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ€–-automerge marks PR as ready to be merged for Mergify a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants