π¨ introduce include_children query parameter for activity monitor / project activity listings (ποΈ)
#7718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7718 +/- ##
==========================================
+ Coverage 87.19% 87.39% +0.20%
==========================================
Files 1786 1753 -33
Lines 69761 68734 -1027
Branches 1203 1047 -156
==========================================
- Hits 60827 60072 -755
+ Misses 8606 8371 -235
+ Partials 328 291 -37
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
matusdrobuliak66
changed the title
matusdrobuliak66
changed the title
include_children query parameter for activity monitor / project activity listings
matusdrobuliak66
requested review from
pcrespov,
sanderegg,
GitHK and
giancarloromeo
as code owners
matusdrobuliak66
added
a:webserver
matusdrobuliak66
changed the title
include_children query parameter for activity monitor / project activity listingsinclude_children query parameter for activity monitor / project activity listings (ποΈ)
matusdrobuliak66
added
the
π€-automerge
|
@mergify queue |
π Waiting for conditions to match
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new query parameter, include_children, to the activity monitor and project activity listings endpoints so that activities for child projects are optionally included. Key changes include:
- Adding and exposing a new function to fetch project UUIDs by root parent project ID.
- Updating computations endpoints and RPC calls to accept a list of project IDs instead of a single project ID.
- Adjusting related tests, database queries, and error messages to support the new filtering functionality.
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/web/server/src/simcore_service_webserver/projects/projects_metadata_service.py | Updated imports and all to expose the new function. |
| services/web/server/src/simcore_service_webserver/projects/_metadata_service.py | Added get_project_uuids_by_root_parent_project_id function. |
| services/web/server/src/simcore_service_webserver/projects/_metadata_repository.py | Added database queries to support filtering by root parent project UUID. |
| services/web/server/src/simcore_service_webserver/director_v2/_controller/computations_rest.py | Revised endpoint parameter types and query parsing to support include_children. |
| services/director-v2/_computations_service.py | Added filtering logic for child projects and updated calls to RPC functions. |
| services/director-v2/api/rpc/_computations.py | Changed API signatures from single project_id to list of project_ids and adjusted downstream calls. |
| Other files (tests, database migrations, and library updates) | Adjusted tests and error messages, and added indexes to support efficient queries. |
Files not reviewed (1)
- services/web/server/src/simcore_service_webserver/api/v0/openapi.yaml: Language not supported
Comments suppressed due to low confidence (2)
services/director-v2/api/rpc/_computations.py:157
- There is a potential KeyError if a taskβs project_uuid is not present in project_uuid_to_iteration; consider adding error handling or a default value.
project_uuid_to_iteration[task.project_uuid],
services/director-v2/_computations_service.py:141
- [nitpick] Consider renaming 'child_projects_with_root' to 'project_ids_with_children' for improved clarity of the variable's purpose.
if include_children:
services/director/src/simcore_service_director/registry_proxy.py
Outdated
Show resolved
Hide resolved
sanderegg
reviewed
May 21, 2025
packages/models-library/src/models_library/projects_metadata.py
Outdated
Show resolved
Hide resolved
pcrespov
approved these changes
May 22, 2025
services/director-v2/src/simcore_service_director_v2/api/rpc/_computations.py
Show resolved
Hide resolved
...ker/src/simcore_service_resource_usage_tracker/services/modules/db/credit_transactions_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_metadata_repository.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_metadata_repository.py
Outdated
Show resolved
Hide resolved
|
GitHK
approved these changes
May 22, 2025
services/director-v2/src/simcore_service_director_v2/api/rpc/_computations.py
Show resolved
Hide resolved
sanderegg
approved these changes
May 22, 2025
matusdrobuliak66
merged commit 066b8a2
into
ITISFoundation:master
134 of 136 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
include_childrenquery parameter for activity monitor / project activity listings (ποΈ)Related issue/s
How to test
Dev-ops