Skip to content

Fix848/dyn services dont start in prod #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sanderegg
Copy link
Member

What do these changes do?

  • get the network name using the full name instead of a part only which can lead to conflict if 2 or more stacks use the same letters in their stack name.

Related issue number

fixes #848

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@sanderegg sanderegg self-assigned this Jun 6, 2019
@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #849 into master will decrease coverage by 14.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #849       +/-   ##
===========================================
- Coverage    71.3%   57.28%   -14.03%     
===========================================
  Files         131      101       -30     
  Lines        5336     4050     -1286     
===========================================
- Hits         3805     2320     -1485     
- Misses       1531     1730      +199
Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 76.54% <0%> (ø) ⬆️
...erver/src/simcore_service_webserver/rest_models.py 0% <0%> (-91.18%) ⬇️
...er/src/simcore_service_webserver/storage_routes.py 24.13% <0%> (-75.87%) ⬇️
...er/src/simcore_service_webserver/users_handlers.py 27.47% <0%> (-72.53%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 26.26% <0%> (-66.67%) ⬇️
...er/src/simcore_service_webserver/login/handlers.py 23.87% <0%> (-63.52%) ⬇️
...core_service_webserver/projects/projects_access.py 25.8% <0%> (-58.07%) ⬇️
...rc/simcore_service_webserver/login/registration.py 38.46% <0%> (-53.85%) ⬇️
...eb/server/src/simcore_service_webserver/statics.py 25% <0%> (-52.78%) ⬇️
...ver/src/simcore_service_webserver/rest_handlers.py 46.66% <0%> (-50%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93f8a7d...d9987d4. Read the comment docs.

@sanderegg sanderegg merged commit 46110c8 into ITISFoundation:master Jun 6, 2019
@sanderegg sanderegg deleted the fix848/dyn_services_dont_start_in_prod branch June 6, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic services do not start in production
4 participants