Skip to content

Disables fake-projects #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2019
Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 6, 2019

What do these changes do?

  • Application does not load template projects via fakes
  • Moves all calls to get fakes under project's db api (in mid term this should e completely removed)

Related issue number

Implements changes in #866

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

Moves all calls to get fakes under project's db api
@ghost
Copy link

ghost commented Jun 6, 2019

DeepCode analyzed this pull request.
There is 1 new info report. 1 info report was fixed.

Click to see more details.

@codecov-io
Copy link

codecov-io commented Jun 6, 2019

Codecov Report

Merging #867 into master will increase coverage by 7.54%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
+ Coverage    71.3%   78.85%   +7.54%     
==========================================
  Files         131       76      -55     
  Lines        5336     2856    -2480     
==========================================
- Hits         3805     2252    -1553     
+ Misses       1531      604     -927
Impacted Files Coverage Δ
...re_service_webserver/projects/projects_handlers.py 86.95% <ø> (+3.11%) ⬆️
...simcore_service_webserver/projects/projects_api.py 100% <ø> (+2%) ⬆️
...src/simcore_service_webserver/projects/__init__.py 88.88% <ø> (-1.86%) ⬇️
...er/src/simcore_service_webserver/studies_access.py 92.78% <100%> (-0.15%) ⬇️
...erver/src/simcore_service_webserver/application.py 92.15% <100%> (ø) ⬆️
...core_service_webserver/projects/projects_access.py 85.71% <100%> (+1.84%) ⬆️
.../simcore_service_webserver/projects/projects_db.py 89.74% <75%> (-0.69%) ⬇️
...r/rest/generated_code/models/inline_response201.py
.../rest/generated_code/models/inline_response2001.py
api/tests/test_repo_data.py
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46110c8...3ec2fa1. Read the comment docs.

@pcrespov pcrespov merged commit a7e9652 into ITISFoundation:master Jun 6, 2019
@pcrespov pcrespov deleted the is866/templates branch June 6, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants