Skip to content

Hotfix/is866 disable fake templates #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jun 6, 2019

What do these changes do?

  • Application does not load template projects via fakes
  • Moves all calls to get fakes under project's db api (in mid term this should e completely removed)

NOTE: these changes are already in master (cherry picked from there) and have tested that work there.

Related issue number

Implements changes in #866

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm

Pedro Crespo added 2 commits June 6, 2019 20:27
Moves all calls to get fakes under project's db api
@ghost
Copy link

ghost commented Jun 6, 2019

DeepCode analyzed this pull request.
There is 1 new info report. 1 info report was fixed.

Click to see more details.

@pcrespov pcrespov marked this pull request as ready for review June 6, 2019 19:00
@pcrespov pcrespov requested review from odeimaiz and sanderegg June 6, 2019 19:00
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@pcrespov pcrespov merged commit 345802a into ITISFoundation:staging Jun 6, 2019
@pcrespov pcrespov deleted the hotfix/is866-disable-fake-templates branch June 25, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants