Skip to content

Timezone utc #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2021
Merged

Timezone utc #104

merged 2 commits into from
Dec 13, 2021

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Dec 13, 2021

We need to keep utc_time_sans_frac in cryptojwt in sync with the implementation in oidcmsg until we can remove it from oidcmsg.

rohe added 2 commits December 13, 2021 13:52
Needed in cryptojwt so eventually should be removed from oidcmsg.
@rohe rohe requested a review from jschlyter December 13, 2021 13:01
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #104 (ca721a3) into main (602ff41) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   77.54%   77.55%   +0.01%     
==========================================
  Files          41       41              
  Lines        4342     4344       +2     
  Branches      841      841              
==========================================
+ Hits         3367     3369       +2     
  Misses        711      711              
  Partials      264      264              
Impacted Files Coverage Δ
src/cryptojwt/jwt.py 76.88% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602ff41...ca721a3. Read the comment docs.

@jschlyter jschlyter self-requested a review December 13, 2021 14:12
@rohe rohe merged commit a7dd24f into main Dec 13, 2021
@peppelinux
Copy link
Member

Can we close this?
#102

@rohe
Copy link
Contributor Author

rohe commented Dec 13, 2021

I think we could.

@jschlyter jschlyter deleted the timezone_utc branch June 22, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants