Skip to content

Atomic keys update #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Conversation

jschlyter
Copy link
Collaborator

Rewrite code so we only update self._keys once and inside the writer. Thorough review required!

@jschlyter jschlyter requested a review from rohe March 4, 2022 12:22
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2022

Codecov Report

Merging #115 (baacdd1) into main (633118d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   77.42%   77.46%   +0.04%     
==========================================
  Files          41       41              
  Lines        4328     4327       -1     
  Branches      838      838              
==========================================
+ Hits         3351     3352       +1     
+ Misses        712      711       -1     
+ Partials      265      264       -1     
Impacted Files Coverage Δ
src/cryptojwt/key_bundle.py 79.17% <100.00%> (-0.03%) ⬇️
src/cryptojwt/jwk/rsa.py 76.37% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 633118d...baacdd1. Read the comment docs.

@jschlyter jschlyter merged commit 0bb1c54 into IdentityPython:main Mar 7, 2022
@jschlyter jschlyter deleted the atomic_keys_update branch March 7, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants