Skip to content

Fix key update #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Fix key update #117

merged 2 commits into from
Mar 14, 2022

Conversation

janste63
Copy link
Contributor

@janste63 janste63 commented Mar 9, 2022

Found a problem in 1.7.0 when updating key bundles with a new set of keys, the old keys were lost.
Fixed typo in a log stmt.
To make this PR complete we should add a new test case to cover this.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2022

Codecov Report

Merging #117 (feef024) into main (633118d) will decrease coverage by 0.15%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   77.42%   77.26%   -0.16%     
==========================================
  Files          41       41              
  Lines        4328     4324       -4     
  Branches      838      836       -2     
==========================================
- Hits         3351     3341      -10     
- Misses        712      718       +6     
  Partials      265      265              
Impacted Files Coverage Δ
src/cryptojwt/key_bundle.py 78.80% <92.30%> (-0.41%) ⬇️
src/cryptojwt/jwk/hmac.py 75.82% <0.00%> (-4.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba2a32...feef024. Read the comment docs.

@jschlyter jschlyter self-requested a review March 14, 2022 10:01
@jschlyter jschlyter self-assigned this Mar 14, 2022
@jschlyter jschlyter merged commit 0647053 into IdentityPython:main Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants