Skip to content

EdDSA (Ed25519/Ed448) #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 25, 2023
Merged

EdDSA (Ed25519/Ed448) #142

merged 15 commits into from
May 25, 2023

Conversation

jschlyter
Copy link
Collaborator

@jschlyter jschlyter commented May 14, 2023

Add support for EdDSA with Ed25519 and Ed448. Basic JWK support for X25519 and X448 also included.

@jschlyter jschlyter marked this pull request as draft May 14, 2023 19:51
@jschlyter
Copy link
Collaborator Author

Some eyes on this from @rohe would be useful.

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2023

Codecov Report

Merging #142 (cb12605) into main (8cb2034) will decrease coverage by 0.94%.
The diff coverage is 61.17%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   77.44%   76.50%   -0.94%     
==========================================
  Files          42       44       +2     
  Lines        4362     4694     +332     
  Branches      982      980       -2     
==========================================
+ Hits         3378     3591     +213     
- Misses        717      808      +91     
- Partials      267      295      +28     
Impacted Files Coverage Δ
src/cryptojwt/tools/keygen.py 0.00% <0.00%> (ø)
src/cryptojwt/tools/keyconv.py 41.04% <28.57%> (-1.46%) ⬇️
src/cryptojwt/key_bundle.py 77.67% <35.48%> (-1.14%) ⬇️
src/cryptojwt/utils.py 75.23% <55.22%> (-7.08%) ⬇️
src/cryptojwt/jwk/okp.py 68.39% <68.39%> (ø)
src/cryptojwt/jwk/jwk.py 79.85% <72.72%> (-0.49%) ⬇️
src/cryptojwt/jws/eddsa.py 80.00% <80.00%> (ø)
src/cryptojwt/exception.py 98.18% <100.00%> (+0.06%) ⬆️
src/cryptojwt/jws/jws.py 80.95% <100.00%> (+0.07%) ⬆️
src/cryptojwt/jws/utils.py 82.92% <100.00%> (+0.87%) ⬆️

... and 1 file with indirect coverage changes

@jschlyter jschlyter requested review from rohe and peppelinux May 16, 2023 13:20
@jschlyter jschlyter marked this pull request as ready for review May 16, 2023 13:21
@jschlyter jschlyter changed the title EdDSA EdDSA (Ed25519/Ed448) May 21, 2023
@jschlyter jschlyter merged commit 330d273 into IdentityPython:main May 25, 2023
@jschlyter jschlyter deleted the eddsa branch May 25, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants