Skip to content

Support for P-256K/ES256K #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Support for P-256K/ES256K #147

merged 3 commits into from
Jul 20, 2023

Conversation

jschlyter
Copy link
Collaborator

Initial support for P-256K/ES256K per RFC 8812

@jschlyter jschlyter marked this pull request as draft July 12, 2023 09:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #147 (4488a73) into main (8cb2034) will decrease coverage by 0.96%.
The diff coverage is 61.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   77.44%   76.48%   -0.96%     
==========================================
  Files          42       44       +2     
  Lines        4362     4699     +337     
  Branches      982      982              
==========================================
+ Hits         3378     3594     +216     
- Misses        717      810      +93     
- Partials      267      295      +28     
Impacted Files Coverage Δ
src/cryptojwt/jwk/__init__.py 77.70% <ø> (+1.35%) ⬆️
src/cryptojwt/jwk/ec.py 74.67% <ø> (ø)
src/cryptojwt/tools/keygen.py 0.00% <0.00%> (ø)
src/cryptojwt/tools/keyconv.py 41.04% <28.57%> (-1.46%) ⬇️
src/cryptojwt/key_bundle.py 77.45% <33.33%> (-1.35%) ⬇️
src/cryptojwt/utils.py 75.23% <55.22%> (-7.08%) ⬇️
src/cryptojwt/jwk/okp.py 68.39% <68.39%> (ø)
src/cryptojwt/jwk/jwk.py 79.85% <72.72%> (-0.49%) ⬇️
src/cryptojwt/jws/eddsa.py 80.00% <80.00%> (ø)
src/cryptojwt/exception.py 98.18% <100.00%> (+0.06%) ⬆️
... and 3 more

@jschlyter jschlyter marked this pull request as ready for review July 12, 2023 14:45
@jschlyter jschlyter requested a review from rohe July 12, 2023 14:45
@rohe rohe merged commit c03d7c8 into IdentityPython:main Jul 20, 2023
@jschlyter jschlyter deleted the p256k branch November 25, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants