Fix missing apu/apv IdentityPython/JWTConnect-Python-CryptoJWT#159 #170
+27
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 76.24% 76.42% +0.17%
==========================================
Files 44 44
Lines 4484 4484
Branches 984 839 -145
==========================================
+ Hits 3419 3427 +8
Misses 777 777
+ Partials 288 280 -8 ☔ View full report in Codecov by Sentry. |
jschlyter
previously approved these changes
Oct 24, 2024
|
I had to delete the agreement information from the parameters, otherwise the changed line wouldn't have been tested. I ran the test against the old and the new implementation, it tests the right thing now. |
jschlyter
approved these changes
Nov 16, 2024
|
Thanks for merging this and cutting a release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is supposed to fix #159, if there's anything I can do please contact me. I'll fill out the contributors agreement now.